Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add credentials-themes to the translation pipeline #383

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: Add credentials-themes to the translation pipeline #383

merged 1 commit into from
Oct 25, 2023

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Jun 9, 2023 •
edited
Loading

feat: Add credentials-themes to the translation pipeline

IMPORTANT: This PR needs openedx/credentials-themes#613 before it's merged.

Refs:
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
see details here

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 9, 2023 •
edited
Loading

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif shadinaif marked this pull request as ready for review June 10, 2023 13:26
@shadinaif
Copy link
Contributor Author

@OmarIthawi @brian-smith-tcril please review

OmarIthawi
OmarIthawi requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credentials-theme is neither and XBlock or Open edX plugin with apps.py, therefore it shouldn't have a link in the edx-platform-links directory.

There's a note saying:

          # Note: Add `module_name` for all edx-platform plugins and XBlocks such as DoneXBlock and completion, but not
          #       for micrsoervices and IDAs such as course-discovery and credentials.

It should add a link to the full document ( https://github.com/openedx/openedx-translations/tree/main/translations/edx-platform-links ) and updates module_name --> python_module_name.

.github/workflows/extract-translation-source-files.yml Outdated Show resolved Hide resolved
@OmarIthawi OmarIthawi self-requested a review June 12, 2023 13:29
@OmarIthawi
Copy link
Member

@shadinaif reminder for the review required changes.

@brian-smith-tcril brian-smith-tcril added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 24, 2023
@OmarIthawi OmarIthawi marked this pull request as draft July 31, 2023 15:53
@OmarIthawi
Copy link
Member

@shadinaif this seems to be a quick one to get it merged. Would you mind checking it out?

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.credentials-themes branch from bdb0790 to dbca334 Compare September 21, 2023 08:47
OmarIthawi
OmarIthawi approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shadinaif!! This is now ready to be merged as soon as the PR below is merged:

@shadinaif shadinaif mentioned this pull request Sep 21, 2023
Closed
@shadinaif shadinaif marked this pull request as ready for review September 21, 2023 09:24
@shadinaif
Copy link
Contributor Author

Thank you @OmarIthawi , I also performed a new test, just in case

It's working fine https://github.com/Zeit-Labs/openedx-translations/pull/75/files#r1332758489

@OmarIthawi OmarIthawi added blocked by other work PR cannot be finished until other work is complete and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 21, 2023
@OmarIthawi OmarIthawi marked this pull request as draft October 18, 2023 06:53
@OmarIthawi
Copy link
Member

I've converted to draft, to avoid accidental merge.

@brian-smith-tcril brian-smith-tcril removed the blocked by other work PR cannot be finished until other work is complete label Oct 18, 2023
@OmarIthawi OmarIthawi marked this pull request as ready for review October 23, 2023 18:35
@OmarIthawi
Copy link
Member

@shadinaif the related openedx/credentials-themes#613 PR has been merged. Please check this one and let me if we should merge it.

@brian-smith-tcril brian-smith-tcril merged commit 2eab5fd into openedx:main Oct 25, 2023
4 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@shadinaif shadinaif mentioned this pull request Nov 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

@OmarIthawi OmarIthawi OmarIthawi approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shadinaif @openedx-webhooks @OmarIthawi @brian-smith-tcril