feat: adds a rudimentary shell that works for dev environments #22
Conversation
We still needed to update the shell’s header code to use the runtime directory instead of frontend-platform. This adjusts those imports. Also adding missing dependencies.
Most of these references are in comments and documentation. Touching the files has also rearranged their imports alphabetically.
This commit also adds a first draft of the steps necessary to convert an MFE to use the shell. Not everything described in those steps actually exists yet. The CLI commands may change, as well, along with the guts of the new webpack.shell.dev.config.js configuration.
We still have two repositories to merge into frontend-base: frontend-component-footer and frontend-plugin-framework. If Renovate pushes commits to main while we're trying to pull in hundreds of commits from those repositories, it makes rebasing on top of renovate's commits nearly impossible. For now, let's just turn off auto-merging of renovate commits until we get these repos in.
Should satisfy the linter.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @davidjoy! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
At least I think this exports it properly; seems to work in apps!
Just tryin to get the test suite to pass here!
|
@davidjoy 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a point-in-time PR. It adds a rudimentary shell application and cleans up references to frontend-platform.
The shell application has been tested by the
use-shellbranch of davidjoy/frontend-app-base-test: https://github.com/davidjoy/frontend-app-base-test/tree/djoy/use-shellIf you check out frontend-base and the use-shell branch of frontend-app-base-test as peer folders, you can add this script to frontend-base to install it as a local dependency of frontend-app-base-test:
"scripts": { ... + "pack:base-test": "npm run build && npm pack && cd ../frontend-app-base-test && npm i ../frontend-base/openedx-frontend-base-1.0.0.tgz && cd ../frontend-base", ... }, ...In frontend-base, run:
And in frontend-app-base-test, run:
On port 8082 you'll see an MFE that uses the shell from frontend-base to wrap modules from frontend-app-base-test.