From 8b50622799609e729d725af14628af98aed5f34d Mon Sep 17 00:00:00 2001 From: David Joy Date: Wed, 3 Jul 2024 11:19:36 -0400 Subject: [PATCH] build: need to install test-app dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A prior commit removed a peerDependency on react in the top-level package.json. This meant that react was no longer installed in the node_modules directory. When eslint runs, that means it encountered this error: /frontend-base/cli/test-app/src/Image.tsx 1:38 error Unable to resolve path to module 'react' import/no-unresolved The test-app (example back in frontend-build) relied on react being installed, since it’s own dependencies weren’t installed. This commit actually runs npm ci on the test-app, as we should have been doing. The fact that it wasn’t breaking in the past was a lucky side effect of how peer dependencies work with npm. --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 743c6279..2216cb84 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,10 @@ jobs: with: node-version: ${{ env.NODE_VER }} - name: Install dependencies - run: npm ci + run: | + npm ci + cd cli/test-app + npm ci - name: Lint run: npm run lint - name: Test