From 4c9143b2b4825ebd167ff05c067f128447ee0394 Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Fri, 1 Nov 2024 00:35:17 +0500 Subject: [PATCH] test: Remove support for Node 18 (#1454) * test: Remove support for Node 18 * chore: update code coverage artifact naming --- .github/workflows/validate.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 5feb86ad88..8634743f6d 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -9,21 +9,16 @@ on: jobs: tests: runs-on: ubuntu-latest - strategy: - matrix: - node: [18, 20] steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version-file: '.nvmrc' - run: make validate.ci - name: Archive code coverage results uses: actions/upload-artifact@v4 with: - name: code-coverage-report-${{ matrix.node }} - # When we're only using Node 20, replace the line above with the following: - # name: code-coverage-report + name: code-coverage-report path: coverage/*.* coverage: runs-on: ubuntu-latest @@ -33,9 +28,7 @@ jobs: - name: Download code coverage results uses: actions/download-artifact@v4 with: - name: code-coverage-report-20 - # When we're only using Node 20, replace the line above with the following: - # name: code-coverage-report + name: code-coverage-report - name: Upload coverage uses: codecov/codecov-action@v4 with: