-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show Programs button if programs are not configured #372
Labels
bug
Report of or fix for something that isn't working as intended
release blocker
Blocks the upcoming release (fix needed)
Milestone
Comments
arbrandes
added
the
bug
Report of or fix for something that isn't working as intended
label
Jul 5, 2024
deborahgu
added
the
needs maintainer attention
Issue or PR specifically needs the attention of the maintainer.
label
Jul 12, 2024
Thanks for the report! Aperture will track this internally as https://2u-internal.atlassian.net/browse/APER-3565. We will discuss this ticket in our next grooming session. |
justinhynes
removed
the
needs maintainer attention
Issue or PR specifically needs the attention of the maintainer.
label
Jul 17, 2024
deborahgu
added
the
needs maintainer attention
Issue or PR specifically needs the attention of the maintainer.
label
Jul 17, 2024
mariajgrimaldi
added
the
release blocker
Blocks the upcoming release (fix needed)
label
Oct 18, 2024
mariajgrimaldi
added
release blocker
Blocks the upcoming release (fix needed)
and removed
release blocker
Blocks the upcoming release (fix needed)
labels
Oct 28, 2024
deborahgu
added
waiting for eng review
PR is ready for review. Review and merge it, or suggest changes.
and removed
needs maintainer attention
Issue or PR specifically needs the attention of the maintainer.
labels
Nov 1, 2024
Both SUPPORT_URL and Programs links are fixed in master. We just need backports, now. @dcoa may be able to help, there. :) |
deborahgu
removed
the
waiting for eng review
PR is ready for review. Review and merge it, or suggest changes.
label
Nov 21, 2024
I've confirmed this is in the Sumac branch as well, so we're done! Thanks @dcoa! |
github-project-automation
bot
moved this from Backlog
to Closed
in Frontend Working Group
Dec 6, 2024
github-project-automation
bot
moved this from In progress
to Done
in Build-Test-Release Working Group
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Report of or fix for something that isn't working as intended
release blocker
Blocks the upcoming release (fix needed)
Description
On a bare installation one sees the Programs button even though no programs are configured in the backend:
The result is a 404 if you click it:
Expected behavior
If no programs are configured in the backend, the button should simply not show.
Implementation
While we could implement this as a config variable, ideally the frontend would detect whether programs are enabled and render the button based on that.
The text was updated successfully, but these errors were encountered: