feat: Profile image on user posts

[vladislavkeblysh]

Description

• Added profile image on user avatar posts
• Added env variable to toggle image display

[openedx-webhooks]

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[itsjeyd]

Hey @vladislavkeblysh, thank you for this contribution!

@jmakowski1123 This seems to be a user-facing change, so we would need a feature ticket for it. Could you please create one?

• Palm backport: feat: Profile image on user posts (palm.master) #573
• Quince backport: feat: Profile image on user posts (quince.master) #575

CC @mphilbrick211

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (3ef8515) to head (a5675d7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   93.17%   93.18%           
=======================================
  Files         161      161           
  Lines        3401     3405    +4     
  Branches      919      923    +4     
=======================================
+ Hits         3169     3173    +4     
  Misses        215      215           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[itsjeyd]

@jmakowski1123 When you get a minute could you please create a feature ticket for this PR and the backports listed above?

[itsjeyd]

@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.

CC @mphilbrick211

[itsjeyd]

@vladislavkeblysh Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#577 and Palm/Quince backports, #582 and Palm/Quince backports).

CC @mphilbrick211

[awais-ansari]

@vladislavkeblysh @itsjeyd I started a thread on the openEdx slack to speed up the process.
CC: @mphilbrick211

[nedbat]

I can let Product handle the question in more detail, but my understanding is that some sites don't want this due to privacy concerns, so it may need to be the operator's choice whether to enable it.

[jmakowski1123]

Apologies for the delay. Lots of open questions regarding this PR, please see here: openedx/platform-roadmap#314 (comment)

[itsjeyd]

Thanks a lot for the update and product feedback @jmakowski1123! 🙂

@vladislavkeblysh Product review will continue via openedx/platform-roadmap#314, the feature ticket for this PR. Please have a look at that ticket when you can and address the questions raised in this comment.

CC @awais-ansari @mphilbrick211

[vladislavkeblysh]

Ready to review!