Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: some default setting not updating with updated default settings #1269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

Description

Some default setting ( Show reset option, Show answer, Randomization) not updating with updated default settings.

Testing instructions

  1. Check in Studio -> Settings -> Advanced settings values for Show reset button for problems, Show answer and Randomization:
    212
  2. Add problem -> check values for options - verify that they are the same as in Advanced settings
    213
  3. For problem change values for same options to some other values (not default), save changes
    214
  4. Click on Edit for problem and set for options same values as the default ones in Advanced settings (as they were in step 2), save changes
  5. Check if new values were set

Actual Result:

Previous values are displayed (from step 3) - not as they were set in step 4

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner September 11, 2024 11:44
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 11, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov force-pushed the fix-return-to-default-values branch from 0c07983 to 3a8485b Compare September 11, 2024 15:04
@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (c7e2bf9) to head (eddcbba).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files        1073     1073           
  Lines       21098    21098           
  Branches     4550     4550           
=======================================
  Hits        19610    19610           
  Misses       1422     1422           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov
Copy link
Contributor Author

hi @KristinAoki
Please look at this fix, some corrections affect your implementation.

@mphilbrick211
Copy link

@DmytroAlipov flagging that new tests have popped up.

@openedx/2u-tnl also flagging so someone can review after. Thanks!

@DmytroAlipov DmytroAlipov force-pushed the fix-return-to-default-values branch from 3a8485b to eddcbba Compare December 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants