-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: some default setting not updating with updated default settings #1269
base: master
Are you sure you want to change the base?
Fix: some default setting not updating with updated default settings #1269
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
0c07983
to
3a8485b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1269 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 1073 1073
Lines 21098 21098
Branches 4550 4550
=======================================
Hits 19610 19610
Misses 1422 1422
Partials 66 66 ☔ View full report in Codecov by Sentry. |
hi @KristinAoki |
@DmytroAlipov flagging that new tests have popped up. @openedx/2u-tnl also flagging so someone can review after. Thanks! |
3a8485b
to
eddcbba
Compare
Description
Some default setting ( Show reset option, Show answer, Randomization) not updating with updated default settings.
Testing instructions
Show reset button for problems
,Show answer
andRandomization
:Actual Result:
Previous values are displayed (from step 3) - not as they were set in step 4