Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary asset upload/deletion for Library Components #1400

Open
ormsbee opened this issue Oct 17, 2024 · 3 comments
Open

Support arbitrary asset upload/deletion for Library Components #1400

ormsbee opened this issue Oct 17, 2024 · 3 comments
Assignees

Comments

@ormsbee
Copy link
Contributor

ormsbee commented Oct 17, 2024

#1398 specifies the ability to add images to an HTML or Problem component via the TinyMCE editor.

But for both debugging and for power user purposes, we're going to want to be able to do direct file upload via the Details tab in the sidebar. This will also allow ProblemBlocks to use static assets when using the advanced editor (which currently has no menu for asset upload). It will also allow for other kinds of assets to be uploaded and linked, like PDFs.

This can go directly under the part of the UI where we already display assets:

image-side-panel

Quoting @bradenmacdonald:

adding a basic "drop file here to upload" to the power user assets section is probably very little work. You can just add a link that displays a ModalDropzone and then call this existing REST API to save the upload.

@ormsbee
Copy link
Contributor Author

ormsbee commented Oct 23, 2024

Ideally, we could also get delete buttons of some sort for the existing assets.

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Oct 23, 2024

@jmakowski1123 @sdaitzman @marcotuts This is ready for acceptance testing on the sandbox. I included a delete button.

(n.b. PR hasn't merged yet)

@ChrisChV
Copy link
Contributor

@jmakowski1123 @sdaitzman @marcotuts Friendly reminder that this is ready for AC testing on the sandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for AC testing
Development

No branches or pull requests

3 participants