Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no validation for combined length of org, number, run #1262

Merged

Conversation

DmytroAlipov
Copy link
Contributor

Description

There's no validation for combined length of organization, course number and course run:

111

For legacy:

222

Fix:

333

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner September 6, 2024 12:50
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (dcf05cd) to head (234cc1d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files        1008     1008           
  Lines       18511    18521   +10     
  Branches     3946     3959   +13     
=======================================
+ Hits        17071    17081   +10     
  Misses       1371     1371           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

@openedx/2u-tnl this is ready for review. Thanks!

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Sep 9, 2024
Comment on lines 204 to 212
{errors[TOTAL_LENGTH_KEY] && (
<Form.Control.Feedback
className="feedback-error"
type="invalid"
hasIcon={false}
>
{errors[TOTAL_LENGTH_KEY]}
</Form.Control.Feedback>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the design of the pages, can you convert this into an <Alert/> that is not dismissable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KristinAoki !
I did. It looks better. Thanks for the tip! But I'm not quite sure if it's implemented well in the context of the code.

12345

@DmytroAlipov DmytroAlipov force-pushed the fix-validation-for-combined-length branch from cfde98c to e5ec2e9 Compare September 9, 2024 17:01
@DmytroAlipov DmytroAlipov force-pushed the fix-validation-for-combined-length branch from e5ec2e9 to 234cc1d Compare September 9, 2024 17:06
@KristinAoki KristinAoki merged commit 513309c into openedx:master Sep 10, 2024
7 checks passed
@DmytroAlipov DmytroAlipov deleted the fix-validation-for-combined-length branch September 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants