-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no validation for combined length of org, number, run #1262
fix: no validation for combined length of org, number, run #1262
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1641bb5
to
cfde98c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 1008 1008
Lines 18511 18521 +10
Branches 3946 3959 +13
=======================================
+ Hits 17071 17081 +10
Misses 1371 1371
Partials 69 69 ☔ View full report in Codecov by Sentry. |
@openedx/2u-tnl this is ready for review. Thanks! |
{errors[TOTAL_LENGTH_KEY] && ( | ||
<Form.Control.Feedback | ||
className="feedback-error" | ||
type="invalid" | ||
hasIcon={false} | ||
> | ||
{errors[TOTAL_LENGTH_KEY]} | ||
</Form.Control.Feedback> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the design of the pages, can you convert this into an <Alert/>
that is not dismissable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KristinAoki !
I did. It looks better. Thanks for the tip! But I'm not quite sure if it's implemented well in the context of the code.
cfde98c
to
e5ec2e9
Compare
e5ec2e9
to
234cc1d
Compare
Description
There's no validation for combined length of organization, course number and course run:
For legacy:
Fix: