feat: rollback_transaction() also cancels external fulfillments #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-8866
branch
2 times, most recently
from
1a7bf1b to
48d9467
Compare
pwnage101
force-pushed
the
pwnage101/ENT-8866
branch
3 times, most recently
from
f673e84 to
5a19dde
Compare
iloveagent57
approved these changes
Jun 26, 2024
This is needed for cases where an external fulfillment has been created, but the subsequent platform fulfillment fails (e.g. due to transient networking issues). Before this PR, the external fulfillment would not get rolled back, resulting in an "orphaned" fulfillment that allows learners to effectively redeem content for free. After this PR, that loophole is fixed. ENT-8866
pwnage101
force-pushed
the
pwnage101/ENT-8866
branch
from
5a19dde to
3de6780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for cases where an external fulfillment has been created, but the subsequent platform fulfillment fails (e.g. due to transient networking issues). Before this PR, the external fulfillment would not get rolled back, resulting in an "orphaned" fulfillment that allows learners to effectively redeem content for free. After this PR, that loophole is fixed.
ENT-8866