Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update makefile to remove extraenous common_constraints.txt. file #202

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

katrinan029
Copy link
Contributor

Description

The make upgrade command was generating an extraneous common_constraints.txt. file as a result of a bug in the Makefile.

Ticket Link

Link to the associated ticket
enterprise-catalog: make upgrade adding extraneous common_contraints.txt.

Testing instructions

To test, check out this branch and run the following commands:

  1. make app-shell
  2. make upgrade

Verify that the common_constraints.txt. file is not being generated.

Merge checklist

  • All reviewers approved
  • CI build is green
  • Documentation updated (not only docstrings)
  • Commits are squashed

Sorry, something went wrong.

@katrinan029 katrinan029 marked this pull request as ready for review February 6, 2024 23:30
@katrinan029 katrinan029 merged commit d787fb2 into main Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants