feat: allow redemption at requested prices #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
commented
Nov 27, 2023
| @@ -499,7 +517,7 @@ def _create_redemption( | |||
| All other exceptions raised during the creation of an enrollment. This should have already triggered | |||
| the rollback of a pending transaction. | |||
| """ | |||
| quantity = -1 * self.price_for_content(content_key) | |||
| quantity = -1 * content_price | |||
There was a problem hiding this comment.
IDK why we made a second call to get the price here - we already have it from calling is_redeemable() further up in the body of redeem().
iloveagent57
commented
Nov 27, 2023
| @@ -549,7 +567,25 @@ def _create_redemption( | |||
|
|
|||
| return ledger_transaction | |||
|
|
|||
| def is_redeemable(self, content_key): | |||
| def validate_requested_price(self, content_key, requested_price_cents, canonical_price_cents): | |||
There was a problem hiding this comment.
borrowed from the enterprise-access implementation
iloveagent57
force-pushed
the
aed/override-price
branch
from
0e0b1ef to
5030bf0
Compare
Assignments (in enterprise-access) contain a field that represents the price of the content at the time of assignment. We need to allow for that price to be passed through to the transaction creation view. ENT-8035
iloveagent57
force-pushed
the
aed/override-price
branch
from
5030bf0 to
e170a4e
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments (in enterprise-access) contain a field that represents the price of the content at the time of assignment. We need to allow for that price to be passed through to the transaction creation view. ENT-8035
See updated API docs at http://localhost:18280/api/schema/redoc/#tag/transactions/operation/api_v2_subsidies_admin_transactions_create
Use curl/postman to make a request to create a new transaction for a price that's slightly different from the true price, e.g.
Merge checklist