Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate subsidy uniqueness with clean() method. #168

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

iloveagent57
Copy link
Contributor

Use a clean method to validate that non-internal-only subsidies must be unique on (reference_id, reference_type), since mysql does not support conditional unique constraints. ENT-7891

Merge checklist

  • All reviewers approved
  • CI build is green
  • Documentation updated (not only docstrings)
  • Commits are squashed

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one clarifying nit-level question.

Use a clean method to validate that non-internal-only subsidies
must be unique on (reference_id, reference_type), since mysql
does not support conditional unique constraints. ENT-7891
@iloveagent57 iloveagent57 merged commit 7dff3d9 into main Oct 31, 2023
8 checks passed
@iloveagent57 iloveagent57 deleted the aed/subsidy-clean branch October 31, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants