-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment changes #35947
Comment changes #35947
Conversation
Open release/quince.custom
…ch-repo/edx-platform-quince into open-release/quince.master
…ch-repo/edx-platform-quince into open-release/quince.master
…ch-repo/edx-platform-quince into open-release/quince.master
…ch-repo/edx-platform-quince into open-release/quince.master
Added usagekey
Changed url to cms
Syntax issue fixes
fixed peer profile issues
Hide staff status profiles in peer profile
edx changes for schedule emails
Letter Grade Implementation
Fixed letter_grade unpack issue
Thanks for the pull request, @Aman-K-Ray! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @Aman-K-Ray can you update the description of the PR to provide context regarding the purpose of your work? This is a large body of work and that would help understand what you are trying to accomplish. |
It was a mistake not a genuine merge request. Sorry for the inconvenience.
…On Wed, 4 Dec, 2024, 03:49 Edward Zarecor, ***@***.***> wrote:
Hi @Aman-K-Ray <https://github.com/Aman-K-Ray> can you update the
description of the PR to provide context regarding the purpose of your
work? This is a large body of work and that would help understand what you
are trying to accomplish.
—
Reply to this email directly, view it on GitHub
<#35947 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMQJFK3KUGZBBMOYEKASUW32DYU53AVCNFSM6AAAAABS5NNC6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJVGY3DKOBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No problem @Aman-K-Ray. Take care. |
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.