Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow blocks lower than units to be bookmarked #35207

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: allow blocks lower than units to be bookmarked #35207

merged 1 commit into from
Dec 11, 2024

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Jul 31, 2024 •
edited
Loading

Description

Adds support to jump/scroll to blocks lower than units if bookmarked. It also fixes an issue with bookmark visit url function where it was not passing query params.

Supporting information

Testing instructions

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

@navinkarkera navinkarkera self-assigned this Jul 31, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 31, 2024
This was referenced Jul 31, 2024
Merged
Open
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 31, 2024
farhaanbukhsh
farhaanbukhsh requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good I just have one question.

openedx/features/course_bookmarks/static/course_bookmarks/js/views/bookmarks_list.js Show resolved Hide resolved
farhaanbukhsh
farhaanbukhsh approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mphilbrick211
Copy link

Hi @navinkarkera! Just flagging that a few additional tests have popped up.

@itsjeyd
Copy link
Contributor

itsjeyd commented Nov 28, 2024

@navinkarkera Please rebase this PR to trigger another build.

@farhaanbukhsh Once we get a green build could you merge the changes? (I see you approved them earlier.)

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). and removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Nov 28, 2024
@navinkarkera
Copy link
Contributor Author

@itsjeyd Done.

@farhaanbukhsh This is ready for merge.

@farhaanbukhsh
Copy link
Member

@navinkarkera some tests are failing

@navinkarkera
feat: allow blocks lower than units to be bookmarked
1dc37de 
Adds support to jump/scroll to blocks lower than units if bookmarked. It
also fixes an issue with bookmark visit url function where it was not
passing query params.
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 11, 2024
@itsjeyd
Copy link
Contributor

itsjeyd commented Dec 11, 2024

@farhaanbukhsh Looks like everything is 🟢 now, so you should be good to merge :)

@farhaanbukhsh farhaanbukhsh merged commit aeddb8a into openedx:master Dec 11, 2024
49 checks passed
@farhaanbukhsh farhaanbukhsh deleted the navin/bookmark branch December 11, 2024 14:36
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh approved these changes

Assignees

@navinkarkera navinkarkera

Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@navinkarkera @openedx-webhooks @mphilbrick211 @itsjeyd @farhaanbukhsh @edx-pipeline-bot