chore: assessment api methods #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsprenkle
reviewed
Aug 14, 2023
| context, error_message = self._parse_example(self.example) | ||
| return { | ||
| 'error_message': error_message, | ||
| 'essay_context': context |
There was a problem hiding this comment.
Is "essay" the original wording? Because it would avoid it if it is not, these are frequently (but not always) essays and using that language could cause confusion.
There was a problem hiding this comment.
was training_essay_context
muselesscreator
force-pushed
the
bw/assessment_apis
branch
2 times, most recently
from
dd599e9 to
6ca7344
Compare
nsprenkle
reviewed
Aug 15, 2023
nsprenkle
reviewed
Aug 15, 2023
muselesscreator
force-pushed
the
bw/assessment_apis
branch
2 times, most recently
from
dd38301 to
f74ea26
Compare
nsprenkle
reviewed
Aug 18, 2023
| def _self_path_and_context(self, key, step_data, with_sub=False): | ||
| return self.SELF_TEMPLATE_PATHS[key], self.self_context(step_data, with_sub) | ||
|
|
||
| def self_path_and_context(self): |
There was a problem hiding this comment.
My preference is to change this from:
- path & context > identify template > proxy to getting context
To:
- path & context > (get path & get context) as 2 separate functions (as in submission_mixin)
In the first approach, you're effectively hiding the get_context function. In the second, path and context are both top-level functions that get assembled by the path_and_context function.
muselesscreator
force-pushed
the
bw/assessment_apis
branch
from
e52268e to
ea8e6dc
Compare
Adds FileAPI to isolate file behaviors
Includes refactors for consistency and missing utils
muselesscreator
force-pushed
the
bw/assessment_apis
branch
from
fac9131 to
b268d24
Compare
Created helper create_test_submission function to simplify testing
muselesscreator
force-pushed
the
bw/assessment_apis
branch
from
4ca4d57 to
be32c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - [ A short summary of what this PR does and why ]
Initial rip of api logic from non-peer assessment mixins.