-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hardcoded copyright #2240
fix: hardcoded copyright #2240
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2240 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 195 195
Lines 21603 21603
Branches 1936 1936
=======================================
Hits 20549 20549
Misses 786 786
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @CodeWithEmad, it looks like this is ready for engineering review! I'll mark it as such now, but let me know if you were planning to make more changes to the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for this fix + cleanup @CodeWithEmad , it works as expected.
Could you fix conflicts so I can merge?
- I tested this: (describe what you tested)
- I read through the code
-
I checked for accessibility issuesN/A - Updates documentation
-
User-facing strings are extracted for translationN/A
- Python code formatted with black - Indentation fixed for Yaml workflows - Makefile cleaned up
12960c8
to
fbef72a
Compare
Sure, @pomegranited. |
This will fix the hardcoded "2023" as the year inside the copyright of the documents. Also, clean up some linting issue and typos