Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcoded copyright #2240

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

CodeWithEmad
Copy link
Member

This will fix the hardcoded "2023" as the year inside the copyright of the documents. Also, clean up some linting issue and typos

@CodeWithEmad CodeWithEmad requested a review from a team as a code owner October 6, 2024 14:55
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (98fbeb4) to head (fbef72a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         195      195           
  Lines       21603    21603           
  Branches     1936     1936           
=======================================
  Hits        20549    20549           
  Misses        786      786           
  Partials      268      268           
Flag Coverage Δ
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 11, 2024
@itsjeyd itsjeyd removed the request for review from a team October 11, 2024 10:02
@itsjeyd
Copy link

itsjeyd commented Oct 11, 2024

Hey @CodeWithEmad, it looks like this is ready for engineering review! I'll mark it as such now, but let me know if you were planning to make more changes to the code.

@itsjeyd itsjeyd requested a review from a team October 11, 2024 10:04
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 11, 2024
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for this fix + cleanup @CodeWithEmad , it works as expected.

Could you fix conflicts so I can merge?

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues N/A
  • Updates documentation
  • User-facing strings are extracted for translation N/A

- Python code formatted with  black
-  Indentation fixed for Yaml workflows
- Makefile cleaned up
@CodeWithEmad
Copy link
Member Author

Sure, @pomegranited.

@pomegranited pomegranited merged commit f4dae20 into openedx:master Oct 29, 2024
17 checks passed
@CodeWithEmad CodeWithEmad deleted the fix/copyright branch October 29, 2024 11:58
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants