refactor: ORA data / UI layers #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsprenkle
force-pushed
the
aurora/bff-datalayer
branch
from
ca0a68f to
7454568
Compare
Using black --line-length=120
This allows more immediate access to static resources and avoids bad pathing lookup
This comment was marked as off-topic.
This comment was marked as off-topic.
Included renaming submission path/context to get submission path/context
Fixes an issue with pathing of resource_string
Refactor of ORA to data APIs and split UI layers
jansenk
reviewed
Sep 12, 2023
| from openassessment.xblock.apis.step_data_api import StepDataAPI | ||
|
|
||
|
|
||
| class SelfAssessmentAPI(StepDataAPI): |
There was a problem hiding this comment.
Are you not getting lint errors that these are missing docstrings?
There was a problem hiding this comment.
@jansenk , those are disabled by our pylint config... though we should probably have them, right @muselesscreator?
jansenk
approved these changes
Sep 12, 2023
|
You've also got some lint failures |
I agree. I also got overruled 🙃 |
|
CLA check, please. |
|
CLA check. |
nedbat
changed the title
nsprenkle
changed the title
|
Closing and reopening to re-run jobs |
|
Replacing with new PR to fix stuck job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - Split of functionality in mixins into data / UI components.
JIRA:
What changed?
xblock/apisxblock/ui_mixins/legacyto replace existing view/handler behaviors from mixins, leveraging our new APIs.xblocktoxblock/utils.Developer Checklist
Testing Instructions
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora