Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Workflows #436

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Refactor Workflows #436

merged 1 commit into from
Nov 1, 2024

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram force-pushed the refactor-workflows branch 2 times, most recently from 1a9b021 to c0dd139 Compare September 12, 2024 16:12
irtazaakram
irtazaakram commented Oct 3, 2024
View reviewed changes
.github/workflows/ci.yml
django-version: ['django42']
db-version: ['mysql80']
python-version: ["3.11", "3.12"]
toxenv: ["django42"] # "quality", "pii_check", "check_keywords"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will enable these checks in next PR as changes are quite a lot.

@irtazaakram irtazaakram marked this pull request as ready for review October 3, 2024 06:22
@irtazaakram irtazaakram requested a review from feanil October 3, 2024 12:08
@irtazaakram irtazaakram mentioned this pull request Oct 7, 2024
Closed
@irtazaakram irtazaakram mentioned this pull request Oct 14, 2024
Closed
@irtazaakram irtazaakram mentioned this pull request Oct 21, 2024
Closed
@irtazaakram
Copy link
Member Author

Hi @feanil, could you please review my PR when you have a moment? Thanks a lot!

@irtazaakram irtazaakram added hacktoberfest-accepted Issue accepted for hacktoberfest participants and removed hacktoberfest-accepted Issue accepted for hacktoberfest participants labels Oct 23, 2024
feanil
feanil reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a couple of questions and one major suggestion and then I think this is good to go.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@irtazaakram irtazaakram mentioned this pull request Oct 28, 2024
Closed
@feanil
Copy link
Contributor

feanil commented Oct 28, 2024

Note that the approval is with the assumption that you'll update to using the docker containers for the ES and Mysql services.

@irtazaakram
Copy link
Member Author

Hey @feanil, thanks for the review. Could you remove the required check build (py312, django42, mysql80) to allow this PR to merge?

@irtazaakram irtazaakram mentioned this pull request Oct 31, 2024
Merged
@feanil feanil merged commit 8872b7f into master Nov 1, 2024
10 checks passed
@feanil feanil deleted the refactor-workflows branch November 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Workflows
2 participants
@irtazaakram @feanil