Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove badger docs that got missed. #2302

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Nov 15, 2024

We dropped badgr as a part of openedx/edx-platform#31541

@sarina
Copy link
Contributor

sarina commented Nov 15, 2024

Curious why we'd remove somethnig from previous release notes when it's just no longer implemented? What about a note at the top of the page indicating that support was dropped in <RELEASE NAME>?

@feanil feanil force-pushed the feanil/drop_dead_badgr_docs branch from dfe3ab3 to 893dd18 Compare November 15, 2024 15:43
@feanil
Copy link
Contributor Author

feanil commented Nov 15, 2024

I added a note to the list to acknowledge that the feature was there but dropped later and that's why there are no docs on the latest version of the docs site.

@sarina
Copy link
Contributor

sarina commented Nov 15, 2024

I don't agree that just removing outdated docs here is the right thing, since this was available until Palm. But, your call I guess.

@feanil
Copy link
Contributor Author

feanil commented Nov 18, 2024

While the code on our side existed till Palm, Badgr has not existed as a service for a while. Having this in the latest doc here confused someone into thinking it was still available and especially since the service it integrates with doesn't exist anymore, I don't see a lot of value in the docs.

@sarina
Copy link
Contributor

sarina commented Nov 19, 2024

Ah! Gotcha, I thought this was simply an integration we removed at some point, but it's a service that no longer exists at all. This makes sense to me.

@feanil feanil force-pushed the feanil/drop_dead_badgr_docs branch from 893dd18 to 89035b2 Compare November 19, 2024 14:27
@feanil feanil enabled auto-merge (rebase) November 19, 2024 14:27
@feanil feanil merged commit ef8a8de into master Nov 19, 2024
10 checks passed
@feanil feanil deleted the feanil/drop_dead_badgr_docs branch November 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants