Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds note about the auto linking flag in LTI Consumer configuration #2190

Conversation

tecoholic
Copy link
Contributor

A new flag was introduced in the LTI Consumer configuration which allows automatically linking LTI users with the edX platform users by matching the email ID. This commit describes the purpose of the flag with its caveats.

Ref: openedx/edx-platform#33310

Date Needed (optional)

If the release date of a feature is known or estimated, provide it to give reviewers guidance on turnaround time.

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks
Copy link

openedx-webhooks commented Sep 28, 2023

Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Cup0fCoffee
Copy link

👍

  • [-] I tested this
  • I read through the code
  • Includes documentation

@pdpinch
Copy link
Contributor

pdpinch commented Oct 4, 2023

Is there a RTD version of this we can look at?

@tecoholic tecoholic force-pushed the tecoholic/auto-linking-lti-users-in-lti-provider branch from e2ff086 to 088f1fd Compare October 5, 2023 09:47
@tecoholic
Copy link
Contributor Author

@pdpinch The previous CI run failed due to some issue with the RTD build. It is available here now.

On a related note, do you happen to know the right person I should ping for reviewing and merging this?

@feanil
Copy link
Contributor

feanil commented Oct 5, 2023

@tecoholic it should probably be reviewed and merged by the same person who reviews and merges openedx/edx-platform#33310, if they don't have merge rights here, they can approve it and tag me and I can merge it for y'all.

@tecoholic tecoholic force-pushed the tecoholic/auto-linking-lti-users-in-lti-provider branch from 5ebb024 to f2e1ed3 Compare November 7, 2023 15:14
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…tion

A new flag was introduced in the LTI Consumer configuration which allows
automatically linking LTI users with the edX platform users by matching
the email ID. This commit describes the purpose of the flag with its caveats.

Ref: openedx/edx-platform#33310
@Agrendalath Agrendalath force-pushed the tecoholic/auto-linking-lti-users-in-lti-provider branch from f2e1ed3 to bb146e0 Compare November 13, 2023 18:39
@Agrendalath
Copy link
Member

@feanil, would you mind merging this PR?

@feanil feanil merged commit bc11319 into openedx:master Nov 14, 2023
6 checks passed
@openedx-webhooks
Copy link

@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants