-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds note about the auto linking flag in LTI Consumer configuration #2190
docs: adds note about the auto linking flag in LTI Consumer configuration #2190
Conversation
Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
en_us/install_operations/source/configuration/lti/configure_lti.rst
Outdated
Show resolved
Hide resolved
👍
|
Is there a RTD version of this we can look at? |
e2ff086
to
088f1fd
Compare
@tecoholic it should probably be reviewed and merged by the same person who reviews and merges openedx/edx-platform#33310, if they don't have merge rights here, they can approve it and tag me and I can merge it for y'all. |
en_us/install_operations/source/configuration/lti/configure_lti.rst
Outdated
Show resolved
Hide resolved
en_us/install_operations/source/configuration/lti/configure_lti.rst
Outdated
Show resolved
Hide resolved
en_us/install_operations/source/configuration/lti/configure_lti.rst
Outdated
Show resolved
Hide resolved
5ebb024
to
f2e1ed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the described behavior matches the implementation from feat: link LTI Provider launches to authenticated users edx-platform#33310
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation
…tion A new flag was introduced in the LTI Consumer configuration which allows automatically linking LTI users with the edX platform users by matching the email ID. This commit describes the purpose of the flag with its caveats. Ref: openedx/edx-platform#33310
f2e1ed3
to
bb146e0
Compare
@feanil, would you mind merging this PR? |
@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
A new flag was introduced in the LTI Consumer configuration which allows automatically linking LTI users with the edX platform users by matching the email ID. This commit describes the purpose of the flag with its caveats.
Ref: openedx/edx-platform#33310
Date Needed (optional)
If the release date of a feature is known or estimated, provide it to give reviewers guidance on turnaround time.
Reviewers
Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.
FYI: Tag anyone else who might be interested in this PR here.
Testing
HTML Version (optional)
Sandbox (optional)
Post-review