Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tip to disable mathjax processing for an element #2183

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Sep 13, 2023

Adds a tip about disabling MathJax rendering for a problem to allow users to display raw functions/expressions containing \ followed by a [ and \ followed by ].

This commit will add a small subsection under this section.

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera 👍

  • I tested this: Tested the documented solution preserves the raw text without MathJax interpretation
  • I read through the code - NA
  • I checked for accessibility issues
  • Includes documentation

@tecoholic
Copy link
Contributor

@jristau1984 Can you help to find the right person to review this?

@jristau1984 jristau1984 merged commit b3e54ab into openedx:master Sep 15, 2023
1 check passed
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants