Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency css-loader to v6 #391

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 11, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
css-loader 5.2.7 -> 6.8.1 age adoption passing confidence

Release Notes

webpack-contrib/css-loader (css-loader)

v6.8.1

Compare Source

v6.8.0

Compare Source

Features
  • use template literal when it possible to prevent Maximum call stack size exceeded (#​1525) (6eb5661)
Bug Fixes
6.7.4 (2023-05-19)
Bug Fixes
6.7.3 (2022-12-14)
Bug Fixes
6.7.2 (2022-11-13)
Bug Fixes
6.7.1 (2022-03-08)
Bug Fixes

v6.7.4

Compare Source

v6.7.3

Compare Source

v6.7.2

Compare Source

v6.7.1

Compare Source

v6.7.0

Compare Source

Features

v6.6.0

Compare Source

Features
  • added the hashStrategy option (ca4abce)
6.5.1 (2021-11-03)
Bug Fixes

v6.5.1

Compare Source

v6.5.0

Compare Source

Features
  • support absolute URL in url() when experiments.buildHttp enabled (#​1389) (8946be4)
Bug Fixes
  • respect nosources in the devtool option (c60eff2)

v6.4.0

Compare Source

Features
  • generate more collision resistant for locals (c7db752)
Bug Fixes
  • classes generation for client and server bundling (303a3a1)

v6.3.0

Compare Source

Features
  • added [folder] placeholder (a0dee4f)
  • added the exportType option with 'array', 'string' and 'css-style-sheet' values (c6d2066)
    • 'array' - the default export is Array with API for style-loader and other
    • 'string' - the default export is String you don't need to-string-loader loader anymore
    • 'css-style-sheet' - the default export is a constructable stylesheet, you can use import sheet from './styles.css' assert { type: 'css' }; like in a browser, more information you can find here
  • supported supports() and layer() functions in @import at-rules (#​1377) (bce2c17)
  • fix multiple merging multiple @media at-rules (#​1377) (bce2c17)
Bug Fixes

v6.2.0

Compare Source

Features
  • allow the exportLocalsConvention option can be a function, useful for named export (#​1351) (3c4b357)

v6.1.0

Compare Source

Features
Bug Fixes

v6.0.0

Compare Source

Notes
  • using ~ is deprecated when the esModules option is enabled (enabled by default) and can be removed from your code (we recommend it) (url(~package/image.png) -> url(package/image.png), @import url(~package/style.css) -> @import url(package/style.css), composes: import from '~package/one.css'; -> composes: import from 'package/one.css';), but we still support it for historical reasons. Why can you remove it? The loader will first try to resolve @import/url()/etc as relative, if it cannot be resolved, the loader will try to resolve @import/url()/etc inside node_modules or modules directories.
  • file-loader and url-loader are deprecated, please migrate on asset modules, since v6 css-loader is generating new URL(...) syntax, it enables by default built-in assets modules, i.e. type: 'asset' for all url()
⚠ BREAKING CHANGES
  • minimum supported Node.js version is 12.13.0
  • minimum supported webpack version is 5, we recommend to update to the latest version for better performance
  • for url and import options Function type was removed in favor Object type with the filter property, i.e. before { url: () => true }, now { url: { filter: () => true } } and before { import: () => true }, now { import: { filter: () => true } }
  • the modules.compileType option was removed in favor the modules.mode option with icss value, also the modules option can have icss string value
  • new URL() syntax used for url(), only when the esModules option is enabled (enabled by default), it means you can bundle CSS for libraries
  • data URI are handling in url(), it means you can register loaders for them, example
  • aliases with false value for url() now generate empty data URI (i.e. data:0,), only when the esModules option is enabled (enabled by default)
  • [ext] placeholder don't need . (dot) before for the localIdentName option, i.e. please change .[ext] on [ext] (no dot before)
  • [folder] placeholder was removed without replacement for the localIdentName option, please use a custom function if you need complex logic
  • [emoji] placeholder was removed without replacement for the localIdentName option, please use a custom function if you need complex logic
  • the localIdentHashPrefix was removed in favor the localIdentHashSalt option
Features
  • supported resolve.byDependency.css resolve options for @import
  • supported resolve.byDependency.icss resolve CSS modules and ICSS imports (i.e. composes/etc)
  • added modules.localIdentHashFunction, modules.localIdentHashDigest, modules.localIdentHashDigestLength options for better class hashing controlling
  • less dependencies
Bug Fixes
  • better performance
  • fixed circular @import
Notes
  • we strongly recommend not to add .css to resolve.extensions, it reduces performance and in most cases it is simply not necessary, alternative you can set resolve options by dependency
5.2.7 (2021-07-13)
Bug Fixes
  • fix crash when source map is unavailable with external URL in [@import](https://togithub.com/import) (bb76fe4)
5.2.6 (2021-05-24)
Bug Fixes
  • always write locals export when css modules/icss enabled (#​1315) (075d9bd)
5.2.5 (2021-05-20)
Bug Fixes
5.2.4 (2021-04-19)
Bug Fixes
5.2.3 (2021-04-19)
Bug Fixes
  • improve performance
5.2.2 (2021-04-16)
Bug Fixes
  • avoid escape nonASCII characters in local names (0722733)
5.2.1 (2021-04-09)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "before 6am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/css-loader-6.x branch from 88b2c2d to d612ed1 Compare January 14, 2022 21:50
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 3 times, most recently from c944ec6 to f878dde Compare January 26, 2022 14:05
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 3 times, most recently from 84707d1 to e312b09 Compare February 4, 2022 21:10
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 7 times, most recently from 06082c9 to 2c7e250 Compare February 16, 2022 17:42
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 3 times, most recently from 97a52f1 to fb08c93 Compare March 4, 2022 11:44
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 2 times, most recently from ee70052 to e384098 Compare March 8, 2022 15:14
Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are enough breaking changes in the 6.x release for me to feel like we should think carefully about accepting this change. Going to block this for now until we can prioritize the investigation further.

@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 6 times, most recently from 506dbc4 to 065ff33 Compare March 22, 2022 20:06
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 4 times, most recently from 436acc0 to d0c52ff Compare March 30, 2022 04:29
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 4 times, most recently from 0a71b34 to 271fddc Compare October 26, 2023 15:48
@feanil
Copy link
Contributor

feanil commented Oct 30, 2023

@justinhynes I don't think this should be blocked. The version of Node used by the checkout action does not change the version of Node used by our testing, for that we use the setup_node action via https://github.com/openedx/credentials-themes/blob/master/.github/workflows/ci.yml#L20-L22

See the github docs for more details: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs

@renovate renovate bot force-pushed the renovate/css-loader-6.x branch from 271fddc to ee2a57d Compare October 31, 2023 15:04
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 5 times, most recently from 7148103 to 5f66d0a Compare November 9, 2023 03:25
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 3 times, most recently from 54c83c6 to fe29fa5 Compare November 21, 2023 18:33
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 4 times, most recently from 24ec484 to fbbda2c Compare November 30, 2023 04:01
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch 5 times, most recently from 15a8817 to 17ebd70 Compare December 11, 2023 20:42
@renovate renovate bot force-pushed the renovate/css-loader-6.x branch from 17ebd70 to a0d862b Compare December 12, 2023 15:18
updating static files
@deborahgu deborahgu dismissed justinhynes’s stale review December 18, 2023 21:06

this doesn't actually update node

@deborahgu deborahgu merged commit cab2567 into master Dec 18, 2023
3 checks passed
@deborahgu deborahgu deleted the renovate/css-loader-6.x branch December 18, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants