Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run tests on python 3.11 #4328

Merged
merged 3 commits into from
May 9, 2024

Conversation

iamsobanjaved
Copy link
Contributor

No description provided.

@e0d
Copy link

e0d commented May 2, 2024

@iamsobanjaved Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

I did notice that the codecoverage check failed on the prior build.

@iamsobanjaved iamsobanjaved force-pushed the iamsobanjaved/py311-tests branch 2 times, most recently from 6b9d3d0 to 6447e53 Compare May 6, 2024 13:12
@iamsobanjaved iamsobanjaved marked this pull request as ready for review May 6, 2024 13:40
@iamsobanjaved iamsobanjaved force-pushed the iamsobanjaved/py311-tests branch 2 times, most recently from ae2ebda to 804f133 Compare May 6, 2024 13:57
@DawoudSheraz DawoudSheraz requested a review from a team May 7, 2024 13:21
@DawoudSheraz DawoudSheraz force-pushed the iamsobanjaved/py311-tests branch from 804f133 to 00efa2c Compare May 7, 2024 13:22
@DawoudSheraz
Copy link
Contributor

@iamsobanjaved Please update PR description, thank you.

Comment on lines 82 to 83
env:
PYTHON_VERSION: 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't semgrep be run across all versions?

Dockerfile Outdated
libmysqlclient-dev \
libssl-dev \
# Current version of Pillow (9.5.0) doesn't provide pre-built wheel for python 3.12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add TODO: at the beginning.

Comment on lines +51 to +53
RUN pip install virtualenv

RUN virtualenv -p python3.8 --always-copy ${DISCOVERY_VENV_DIR}
RUN virtualenv -p python${PYTHON_VERSION} --always-copy ${DISCOVERY_VENV_DIR}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isn't venv recommended for Py3? Just wondering if this be venv instead of virtualenv.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, both should work.

@feanil feanil linked an issue May 8, 2024 that may be closed by this pull request
echo "PYTHON_VERSION=$FORMATTED_VERSION" >> $GITHUB_ENV

# Output formatted version for use in subsequent steps
echo "Using Python Version: $PYTHON_VERSION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] PYTHON_VERSION is still undefined here.
From the docs
The step that creates or updates the environment variable does not have access to the new value, but all subsequent steps in a job will have access

Dockerfile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@feanil feanil force-pushed the iamsobanjaved/py311-tests branch from 6a0c003 to 1f94038 Compare May 9, 2024 14:45
@feanil feanil merged commit de9e6d0 into openedx:master May 9, 2024
26 checks passed
@iamsobanjaved iamsobanjaved deleted the iamsobanjaved/py311-tests branch May 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[course-discovery] Test Python 3.11 and 3.12
6 participants