-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: run tests on python 3.11 #4328
build: run tests on python 3.11 #4328
Conversation
@iamsobanjaved Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run. I did notice that the codecoverage check failed on the prior build. |
6b9d3d0
to
6447e53
Compare
ae2ebda
to
804f133
Compare
804f133
to
00efa2c
Compare
@iamsobanjaved Please update PR description, thank you. |
.github/workflows/ci.yml
Outdated
env: | ||
PYTHON_VERSION: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't semgrep be run across all versions?
Dockerfile
Outdated
libmysqlclient-dev \ | ||
libssl-dev \ | ||
# Current version of Pillow (9.5.0) doesn't provide pre-built wheel for python 3.12, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add TODO: at the beginning.
RUN pip install virtualenv | ||
|
||
RUN virtualenv -p python3.8 --always-copy ${DISCOVERY_VENV_DIR} | ||
RUN virtualenv -p python${PYTHON_VERSION} --always-copy ${DISCOVERY_VENV_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: isn't venv recommended for Py3? Just wondering if this be venv instead of virtualenv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, both should work.
.github/workflows/ci.yml
Outdated
echo "PYTHON_VERSION=$FORMATTED_VERSION" >> $GITHUB_ENV | ||
|
||
# Output formatted version for use in subsequent steps | ||
echo "Using Python Version: $PYTHON_VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] PYTHON_VERSION is still undefined here.
From the docs
The step that creates or updates the environment variable does not have access to the new value, but all subsequent steps in a job will have access
6a0c003
to
1f94038
Compare
No description provided.