Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] need a codecov token for frontend-app-learner-record #1308

Open
deborahgu opened this issue Nov 19, 2024 · 3 comments
Open

[GH Request] need a codecov token for frontend-app-learner-record #1308

deborahgu opened this issue Nov 19, 2024 · 3 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@deborahgu
Copy link
Member

Repository

frontend-app-learner-record

Urgency

Low (2 weeks)

Requested Change

It looks like the repository might be missing a codecov access token.

Reasoning

The PR to update codecov failed, even though the token is called for in the action.

https://github.com/openedx/frontend-app-learner-record/actions/runs/11883989894/job/33164769383?pr=443

gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
codecov: OK
==> CLI integrity verified

 -> Token of length 0 detected
==> Running create-commit
      ./codecov  create-commit --fail-on-error --git-service github
info - 2024-11-18 21:40:16,776 -- ci service found: github-actions
info - 2024-11-18 21:40:17,195 -- Process Commit creating complete
error - 2024-11-18 21:40:17,195 -- Commit creating failed: {"message":"Token required because branch is protected"}
==> Failed to create-commit
    Exiting...
Error: Process completed with exit code 1.
@deborahgu deborahgu added the github-request Request for change to access level or settings in the openedx GitHub organization. label Nov 19, 2024
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@sarina
Copy link
Contributor

sarina commented Nov 20, 2024

@deborahgu I notice our reference codecov (https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov#1.-Code-Changes-(done-by-any-developer%2C-merged-by-someone-with-repo-write-access)) defines some stuff that's not defined in https://github.com/openedx/frontend-app-learner-record/blob/master/codecov.yml, like enabled or target above 0%. Perhaps it's never run before? I'll look into the token when I have free time tomorrow, but wanted to flag this as I don't really know if this makes a difference.

@sarina sarina self-assigned this Nov 20, 2024
@sarina
Copy link
Contributor

sarina commented Nov 21, 2024

OK, as per https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov#4.-Add-a-CodeCov-repository-secret-(done-by-a-GitHub-org-admin%2C-at-Axim-for-openedx), we have codecov token globally so I shouldn't have to add something specific to your repo. Could you check that codecov has ever run? Do you know how codecov is working on other repos?

@sarina sarina moved this from Backlog to Blocked in Axim Engineering Tasks Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Blocked
Development

No branches or pull requests

2 participants