1d2d patch #207
Merged
1d2d patch #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test the desktop
Capabilities added to port 1D parameterizations into 2D using a central rotation grid
christavanijzendoorn
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Looks good! Some small things:
The chosen solver was changed in the example cases from trunk to steadystate. I understand that that was necessary for the testing. Do we want the cases to run with the steadystate solver in the future too?
Did you intend to upload the plots.ipynb in the example folder?
It's necessary to document this well. I'm thinking that the Model Setup section in the new documentation might be suitable.
|
Thanks @christavanijzendoorn , I have deleted the plots notebook, that should indeed not have been there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides support for setting up a quasi 2D model for 1D simulations.
It turns out that process implementations and some solvers are easier to implement in 2D.
The code reads 1D input and creates the 2nd dimension based copying the 1D input to 3 grid cells in the model.
The code outputs just 1D matrices