From 95e7bf8bb964f3ddccf746473539ec249a36a577 Mon Sep 17 00:00:00 2001
From: Darren Loher <dloher@google.com>
Date: Tue, 17 Oct 2023 10:29:08 -0700
Subject: [PATCH 1/3] Clarify RebootMethod

---
 system/system.proto | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/system/system.proto b/system/system.proto
index ae4b1f8c..7790fb47 100644
--- a/system/system.proto
+++ b/system/system.proto
@@ -29,7 +29,7 @@ import "types/types.proto";
 
 option go_package = "github.com/openconfig/gnoi/system";
 
-option (types.gnoi_version) = "1.1.1";
+option (types.gnoi_version) = "1.1.2";
 
 // The gNOI service is a collection of operational RPC's that allow for the
 // management of a target outside of the configuration and telemetry pipeline.
@@ -98,7 +98,7 @@ message SwitchControlProcessorResponse {
 }
 
 // A RebootRequest requests the specified target be rebooted using the specified
-// method after the specified delay.  Only the DEFAULT method with a delay of 0
+// method after the specified delay.  Only the COLD method with a delay of 0
 // is guaranteed to be accepted for all target types.
 message RebootRequest {
   RebootMethod method = 1;
@@ -118,6 +118,8 @@ message RebootResponse {
 // A RebootMethod determines what should be done with a target when a Reboot is
 // requested.  Only the COLD method is required to be supported by all
 // targets.  Methods the target does not support should result in failure.
+// 
+// If a target does not support a method, `INVALID_ARGUEMENT` should be returned.
 //
 // It is vendor defined if a WARM reboot is the same as an NSF reboot.
 enum RebootMethod {

From fee0549f0d37d8986d79f858daeb390bb7e7483d Mon Sep 17 00:00:00 2001
From: Darren Loher <dloher@google.com>
Date: Tue, 17 Oct 2023 10:30:29 -0700
Subject: [PATCH 2/3] Update system.proto

---
 system/system.proto | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/system/system.proto b/system/system.proto
index 7790fb47..f43c4fa6 100644
--- a/system/system.proto
+++ b/system/system.proto
@@ -119,7 +119,8 @@ message RebootResponse {
 // requested.  Only the COLD method is required to be supported by all
 // targets.  Methods the target does not support should result in failure.
 // 
-// If a target does not support a method, `INVALID_ARGUEMENT` should be returned.
+// If a target does not support a method, `INVALID_ARGUEMENT` should be
+// returned.
 //
 // It is vendor defined if a WARM reboot is the same as an NSF reboot.
 enum RebootMethod {

From e45d763d1c745d0baa5318713a0a726cb7a0f319 Mon Sep 17 00:00:00 2001
From: Darren Loher <dloher@google.com>
Date: Tue, 17 Oct 2023 10:38:10 -0700
Subject: [PATCH 3/3] Update system.proto

---
 system/system.proto | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/system/system.proto b/system/system.proto
index f43c4fa6..5d8cdf4b 100644
--- a/system/system.proto
+++ b/system/system.proto
@@ -117,10 +117,8 @@ message RebootResponse {
 
 // A RebootMethod determines what should be done with a target when a Reboot is
 // requested.  Only the COLD method is required to be supported by all
-// targets.  Methods the target does not support should result in failure.
-// 
-// If a target does not support a method, `INVALID_ARGUEMENT` should be
-// returned.
+// targets.  A target should return 'INVALID_ARGUMENT` if UNKNOWN or any other
+// unsupported method is called.
 //
 // It is vendor defined if a WARM reboot is the same as an NSF reboot.
 enum RebootMethod {