From 95e7bf8bb964f3ddccf746473539ec249a36a577 Mon Sep 17 00:00:00 2001 From: Darren Loher Date: Tue, 17 Oct 2023 10:29:08 -0700 Subject: [PATCH] Clarify RebootMethod --- system/system.proto | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/system/system.proto b/system/system.proto index ae4b1f8c..7790fb47 100644 --- a/system/system.proto +++ b/system/system.proto @@ -29,7 +29,7 @@ import "types/types.proto"; option go_package = "github.com/openconfig/gnoi/system"; -option (types.gnoi_version) = "1.1.1"; +option (types.gnoi_version) = "1.1.2"; // The gNOI service is a collection of operational RPC's that allow for the // management of a target outside of the configuration and telemetry pipeline. @@ -98,7 +98,7 @@ message SwitchControlProcessorResponse { } // A RebootRequest requests the specified target be rebooted using the specified -// method after the specified delay. Only the DEFAULT method with a delay of 0 +// method after the specified delay. Only the COLD method with a delay of 0 // is guaranteed to be accepted for all target types. message RebootRequest { RebootMethod method = 1; @@ -118,6 +118,8 @@ message RebootResponse { // A RebootMethod determines what should be done with a target when a Reboot is // requested. Only the COLD method is required to be supported by all // targets. Methods the target does not support should result in failure. +// +// If a target does not support a method, `INVALID_ARGUEMENT` should be returned. // // It is vendor defined if a WARM reboot is the same as an NSF reboot. enum RebootMethod {