add StartedTestStep type state #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- similar to #1, this type pattern disallows steps from doing invalid operations, like logging when the step hasnt started yet - also same reasoning as in #1 around commenting out the `scope` method on TestStep Signed-off-by: mimir-d <[email protected]>
njordr
reviewed
Oct 8, 2024
| } | ||
|
|
||
| // /// Builds a scope in the [`TestStep`] object, taking care of starting and |
There was a problem hiding this comment.
comment was above
also same reasoning as in #1 around commenting out the scope method on TestStep
im temporarily disabling those until im happy with a semantically correct solution for the scopes. Issue is that async impls cannot capture the lifetimes of things used inside them (current rust syntax limitation). I'm gonna re-enable them as boxed futures in a later PR, but gated behind a feature flag, so that people explicitly opt-in (until maybe we get the missing rust feature in the future)
njordr
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopemethod on TestStep