Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible violation of spec in step.add_extension #22

Open
mimir-d opened this issue Oct 12, 2024 · 0 comments
Open

possible violation of spec in step.add_extension #22

mimir-d opened this issue Oct 12, 2024 · 0 comments

Comments

@mimir-d
Copy link
Contributor

mimir-d commented Oct 12, 2024

Step extension api is defined as following

async fn add_extension<S: serde::Serialize>(&self, name: &str, any: S)

This means it will accept any Serialize, including primitive types (eg. string, u32, etc). Per the spec, this is incorrect, and we should only accept full objects.

This issue is for tracking and ideas how to fix this. At the current moment, I'm not aware of a way to specify a trait bound only for structs.

cc @njordr

mimir-d added a commit that referenced this issue Oct 12, 2024
- File object had a badly named field
- remove an extension example entry; see #22 for details

Signed-off-by: mimir-d <[email protected]>
mimir-d added a commit that referenced this issue Oct 12, 2024
- File object had a badly named field
- remove an extension example entry; see #22 for details

Signed-off-by: mimir-d <[email protected]>
mimir-d added a commit that referenced this issue Oct 12, 2024
- File object had a badly named field
- remove an extension example entry; see #22 for details

Signed-off-by: mimir-d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant