Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Member Selection Modes For ECMP and LAG #2078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkadia-marvell
Copy link

@dkadia-marvell dkadia-marvell commented Sep 19, 2024

This proposal introduces the below two types of light weight static member selection modes for ECMP/LAG.

  • Random
  • Round Robin

@dkadia-marvell dkadia-marvell force-pushed the dkadia_static_mem_selection_mode branch from 5b57582 to 7a58a12 Compare November 13, 2024 06:41
@dkadia-marvell dkadia-marvell force-pushed the dkadia_static_mem_selection_mode branch from 7a58a12 to f0614a3 Compare November 14, 2024 12:41
@rck-innovium
Copy link
Contributor

@JaiOCP @tjchadaga

Summary of the discussion on 11/14/2024

  1. [Jai] The option to enable packet spraying is in practice needed at the Switch level and not at a per Next Hop Group level.
  2. [Jai] A possible interpretation of SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_ALGORITHM:SAI_HASH_ALGORITHM_RANDOM is to enable packet spraying at a switch level.
    [Ravi] The only description available in the community is: /** Random-based hash algorithm */. This suggests it is still a hash algorithm i.e., it hashes on some fields of the packet. A possible example of such an algorithm could be: https://patents.google.com/patent/US8503456

Next steps agreed:

[Ravi] and [Jai] to see if there are use-cases for enabling packet-spraying at a per NHG granularity instead of switch level. We should also see what happens to telemetry packets, control packets etc. We will discuss offline over the PR and if needed use a follow up meeting.

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants