Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site owner #90

Open
peterdudfield opened this issue Jan 4, 2024 · 5 comments
Open

Add site owner #90

peterdudfield opened this issue Jan 4, 2024 · 5 comments

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Jan 4, 2024

Detailed Description

Add an optional owner in the site

Context

  • good to know who the owner is. This could the owner of the site, or where we are pulling the data from
  • we could create a seperate table for this, but perhaps keeping it simple for the moment is good.

Possible Implementation

  • Add column to Site
  • Can be a string
  • The default can be None
@peterdudfield peterdudfield added the good first issue Good for newcomers label Jan 4, 2024
@peterdudfield peterdudfield changed the title Add client name Add site owner Jan 5, 2024
@anupamkarn
Copy link

Hi,

I stumbled upon this issue, but I wasn't able to understand the issue here could you please elaborate it a bit more? I am relatively new to open-source contribution and would like to check if I can contribute for it?

Thanks

@peterdudfield
Copy link
Contributor Author

@BraunRudolf
Copy link
Contributor

Hi @peterdudfield, I could implement this (if still relevant)

Just to be sure, SiteGroupSQL doesn't need an owner column?

@peterdudfield
Copy link
Contributor Author

Hi @peterdudfield, I could implement this (if still relevant)

Just to be sure, SiteGroupSQL doesn't need an owner column?

Yea that would be great. Yea only in "site"

@BraunRudolf BraunRudolf mentioned this issue Jun 24, 2024
7 tasks
@BraunRudolf
Copy link
Contributor

@peterdudfield could you elaborate what's the difference between the new field and dno?

owner = sa.Column(sa.String(255), comment="The name of the site owner")
dno = sa.Column(sa.String(255), comment="The Distribution Node Operator that owns the site")

@peterdudfield peterdudfield removed the good first issue Good for newcomers label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants