Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Don't reshape_time_as_batch in GSPQueryGenerator! #162

Open
Tracked by #148
JackKelly opened this issue Jun 22, 2022 · 0 comments
Open
Tracked by #148

Don't reshape_time_as_batch in GSPQueryGenerator! #162

JackKelly opened this issue Jun 22, 2022 · 0 comments
Assignees
@JackKelly
Labels
enhancement New feature or request

Comments

@JackKelly
Copy link
Member

JackKelly commented Jun 22, 2022 •
edited
Loading

Instead, always return (example, time, query_dim), and reshape to (example * time, 1, dim) in SatelliteTransformer.forward, just after going through the gsp_query_generator. But need to ensure we mask future "actual" data!

Then we can simply add in history (if we want it) in the calling code. And then reshape.

And do #144
@JackKelly JackKelly mentioned this issue Jun 22, 2022
Open
39 tasks
@JackKelly JackKelly changed the title Don't reshape_time_as_batch in GSPQueryGenerator! Instead, always return (example, time, query_dim), and reshape to (example * time, 1, dim) in SatelliteTransformer.forward, just after going through the gsp_query_generator. But need to ensure we mask future "actual" data! Don't reshape_time_as_batch in GSPQueryGenerator! Jun 22, 2022
@JackKelly JackKelly self-assigned this Jun 22, 2022
@JackKelly JackKelly added the enhancement New feature or request label Jun 22, 2022
@JackKelly JackKelly moved this to Todo in Nowcasting Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JackKelly JackKelly

Labels
enhancement New feature or request
Projects
No open projects
Nowcasting
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackKelly