Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

[META] forecast 8 hrs into the future #133

Closed
10 of 15 tasks
JackKelly opened this issue Jun 15, 2022 · 7 comments
Closed
10 of 15 tasks

[META] forecast 8 hrs into the future #133

JackKelly opened this issue Jun 15, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@JackKelly
Copy link
Member

JackKelly commented Jun 15, 2022

@JackKelly JackKelly self-assigned this Jun 15, 2022
@JackKelly JackKelly added the enhancement New feature or request label Jun 15, 2022
@JackKelly JackKelly moved this to Todo in Nowcasting Jun 15, 2022
@JackKelly
Copy link
Member Author

JackKelly commented Jun 15, 2022

Maybe the simplest thing to do is to not filter by the Sun's angle at all, and maybe extend the forecast horizon to, like, 24 hours so every example is guaranteed to have some daylight and nighttime. Although, of course, the HRV imagery won't show anything useful at night!

So each example could start at literally any time of day (00:00, 06:55, 12:00, etc.)

@JackKelly
Copy link
Member Author

Any thoughts about the idea in the comment immediately above this comment, @peterdudfield and @jacobbieker?

@peterdudfield
Copy link
Contributor

peterdudfield commented Jun 15, 2022

I think its not crazy, to just do full 24 hours start time. Could always look into it if it really starts effecting performance?
But as a good default, probably worth trying

@peterdudfield
Copy link
Contributor

The your MAE will probably go down? easier to predict at night. Have to think how we compare that properly

@peterdudfield
Copy link
Contributor

peterdudfield commented Jun 15, 2022

I would stick to a 8 hour horizon at the moment though, just 24 hours start time.

let's get that working first, and then we can think about extending

@JackKelly
Copy link
Member Author

All sounds good!

And, yeah, I'd need to make sure the validation metrics are computed in the same way (using only daylight hours).

@JackKelly JackKelly changed the title To forecast 8 hrs into the future, need t0 times to be any time during daylight [META] forecast 8 hrs into the future Jun 15, 2022
@jacobbieker
Copy link
Member

Sorry for being a bit delayed with this, but yeah, agree with peter, just have it start at any time and the 8 hour horizon,

@JackKelly JackKelly moved this from Todo to In Progress in Nowcasting Jun 16, 2022
Repository owner moved this from In Progress to Done in Nowcasting Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants