You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposal:
The current serialization logic in _DataPipeSerializationWrapper can benefit from better exception handling, particularly when neither pickle nor dill is available. A more informative error message could be helpful in such cases to guide users in resolving the issue.
Suggested Change:
Add custom exceptions or raise ImportError with clear and meaningful error messages when neither pickle nor dill are available for serialization.
Example error message: "Neither pickle nor dill are available for serialization. Please install one of them to proceed."
Benefits:
Users will have a clearer understanding of what went wrong and how to fix it.
This could improve the overall user experience by providing actionable feedback.
@Sukh-P , I believe this improvement would be a great addition to the project. It will make debugging easier for users who encounter serialization issues. Looking forward to your thoughts and feedback on this!
Thanks for considering this suggestion!
The text was updated successfully, but these errors were encountered:
Thanks for the suggestion on improving this repo, I would suggest however since we are planning on deprecating/not supporting this library at some point next year that if you are looking for improvements to be made that this is focussed on our ocf-data-sampler library which is the replacement for this library
(as is mentioned in the README of this repo). You can check out the issues there and highlight any other improvements you think would be useful. I hope that is alright, thanks.
Proposal:
The current serialization logic in
_DataPipeSerializationWrapper
can benefit from better exception handling, particularly when neitherpickle
nordill
is available. A more informative error message could be helpful in such cases to guide users in resolving the issue.Suggested Change:
ImportError
with clear and meaningful error messages when neitherpickle
nordill
are available for serialization."Neither pickle nor dill are available for serialization. Please install one of them to proceed."
Benefits:
@Sukh-P , I believe this improvement would be a great addition to the project. It will make debugging easier for users who encounter serialization issues. Looking forward to your thoughts and feedback on this!
Thanks for considering this suggestion!
The text was updated successfully, but these errors were encountered: