Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Exception Handling in _DataPipeSerializationWrapper for Missing Serialization Libraries #370

Open
SophiaLi20 opened this issue Nov 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@SophiaLi20
Copy link

Proposal:
The current serialization logic in _DataPipeSerializationWrapper can benefit from better exception handling, particularly when neither pickle nor dill is available. A more informative error message could be helpful in such cases to guide users in resolving the issue.

Suggested Change:

  • Add custom exceptions or raise ImportError with clear and meaningful error messages when neither pickle nor dill are available for serialization.
  • Example error message:
    "Neither pickle nor dill are available for serialization. Please install one of them to proceed."

Benefits:

  • Users will have a clearer understanding of what went wrong and how to fix it.
  • This could improve the overall user experience by providing actionable feedback.

@Sukh-P , I believe this improvement would be a great addition to the project. It will make debugging easier for users who encounter serialization issues. Looking forward to your thoughts and feedback on this!
Thanks for considering this suggestion!

@SophiaLi20 SophiaLi20 added the enhancement New feature or request label Nov 29, 2024
@Sukh-P
Copy link
Member

Sukh-P commented Dec 2, 2024

Hi @SophiaLi20,

Thanks for the suggestion on improving this repo, I would suggest however since we are planning on deprecating/not supporting this library at some point next year that if you are looking for improvements to be made that this is focussed on our ocf-data-sampler library which is the replacement for this library
(as is mentioned in the README of this repo). You can check out the issues there and highlight any other improvements you think would be useful. I hope that is alright, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants