Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'is training' #348

Open
peterdudfield opened this issue Jul 29, 2024 · 4 comments
Open

Remove 'is training' #348

peterdudfield opened this issue Jul 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@peterdudfield
Copy link
Contributor

There should be no difference between training abd production

Detailed Description

Should remove any is trainingor is production flags

Context

Good to tidy up

This flag might do nothing due to coarsen issue

Possible Implementation

Remove flag, check its not used anyway else
@peterdudfield peterdudfield added the enhancement New feature or request label Jul 29, 2024
@peterdudfield
Copy link
Contributor Author

Might be useful #342

@peterdudfield peterdudfield mentioned this issue Jul 29, 2024
Open
@peterdudfield
Copy link
Contributor Author

For example production: bool = False,

@peterdudfield
Copy link
Contributor Author

https://github.com/openclimatefix/ocf_datapipes/blob/main/ocf_datapipes%2Ftraining%2Fwindnet.py#L244

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Jul 29, 2024 •
edited
Loading

We could have a method on thr configuration that sets all random drop outs to zero.

This is what some of the production flag does right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterdudfield