-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check physical limits of nwp data when data is loaded #337
Comments
hey @peterdudfield can I take up this issue? |
yes please |
are we planning to have a dynamic setting for the limits or are we considering statically typing it in form of a dict like:
|
I think a dictionary like that would be good |
the means and stds are here. I wonder if you do mean - 5std, mean + 5std, and see what those umbers look like? |
makes sense |
Hm, they seems a bit tight. 273 is 0 degrees, so the limits there are -4 degrees to 17 degrees. I wonder for temperature we should just do -20 deg up to 50 deg, or perhaps 250 to 330 to be safe. Perhaps you could write out the other ones and I can try to review and see if any need adjusting |
gottcha, I'm placing a the limit range at (250, 330) |
Great stuff! |
Detailed Description
Would be good to check the physical limits of nwp data e.g check temperature is between -100 and 100.
This should be only used in inference
Context
Possible Implementation
The text was updated successfully, but these errors were encountered: