-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test out Xarray Tensorstore Backend #198
Comments
SGTM! Relevant links:
And reasons to believe that TensorStore might be faster than zarr-python: |
I would like to take this issue. I'm new here. how these stuff works? |
Hi! That's great! For this, the primary place that things would need to be updated would be the files in
Ideally, it should be possible to just swap out the
|
@jacobbieker, just updating that I've tried to switch to xarray_tensorstore.open_zarr(path), but I've got the following problem in the line after when sortby('time'). |
Hi, thanks for looking into this! If you can open the zarr, which you can since you got to that line, the dependencies should not be the problem then, I don't think. The TensorStore implementation might not be mature enough for this then? But not really sure. I thought xarray-tensorstore uses Zarr-python for the metadata, so the sorting should work with that, but yeah, sorry its not much help. |
Yeah, they do use zarr-python, but the problem is when trying to deep copy the dataset. |
This should be fixed in the latest 0.1.1 release of Xarray-Tensorstore. |
indeed, it works. thanks @shoyer. |
Hi, yeah, a good benchmark would be a single satellite zarr, like this one: gs://public-datasets-eumetsat-solar-forecasting/satellite/EUMETSAT/SEVIRI_RSS/v4/2023_hrv.zarr And okay, thanks, yeah, if it is a lot faster, we can probably fine a workaround to that issue. |
Update from my testing: Tensorstore does not support compressors not on this list https://google.github.io/tensorstore/driver/zarr/index.html#json-driver/zarr/Compressor and so can't open most of the OCF Zarrs which are compressed with |
Should we close this? |
I think we should leave it open for now, I'll close the issues related to adding support though. @dfulu was going to add a small example notebook and such showing the testing results to have it recorded here. |
https://github.com/google/xarray-tensorstore
Detailed Description
We have been trying to speed up access from zarr for quite awhile. Tensorstore might help, and Google recently made public a backend for xarray that uses Tensorstore.
@JackKelly
The text was updated successfully, but these errors were encountered: