Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to select only the cloest PV systems #102

Open
peterdudfield opened this issue Nov 17, 2022 · 5 comments
Open

Option to select only the cloest PV systems #102

peterdudfield opened this issue Nov 17, 2022 · 5 comments
Assignees

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

When choosing PV sytesm for a example, option to only choose the closest ones

Context

if there are 1000 system in the system, and we want to only get 16 systems, maybe its best to get the PV systems that are closest,
on the other hand, having a random selection means we could have lots of PV systems from a wide range

Possible Implementation

put something when we sleect the pv systems in here

@peterdudfield
Copy link
Contributor Author

Would be interested in your thoughts @JackKelly and @jacobbieker

@jacobbieker
Copy link
Member

I would probably be inclined to leave it for more random systems. If you want only PV systems in a certain area, then you can chain together cropping a spatial area of the PV data, and then choosing N PV systems. It might be worth having a separate one that chooses the N closest systems, but I think that would just be almost the same.

@peterdudfield
Copy link
Contributor Author

Yea, i thought it would just be an option in that data pipe, either random or closest, like method='random' or closest

@jacobbieker
Copy link
Member

Ah yeah, in which case, yeah, adding it makes sense to me then, we probably want to get the N closest ones for like pseudolabelling as well

@peterdudfield
Copy link
Contributor Author

ok, ill give it a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants