You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The process_and_combine.py file has two versions of the function
process_and_combine_datasets() which is only used in PVNetUKRegional
process_and_combine_site_sample_dict() which is only used in SitesDataset
I think process_and_combine_datasets() and process_and_combine_site_sample_dict() should either be refactored to share more code (there is a lot of copy-pasting going on) or they should be moved into pvnet_uk_regional.py and site.py respectively to match their specialised usage.
The text was updated successfully, but these errors were encountered:
The
process_and_combine.py
file has two versions of the functionprocess_and_combine_datasets()
which is only used in PVNetUKRegionalprocess_and_combine_site_sample_dict()
which is only used in SitesDatasetI think
process_and_combine_datasets()
andprocess_and_combine_site_sample_dict()
should either be refactored to share more code (there is a lot of copy-pasting going on) or they should be moved intopvnet_uk_regional.py
andsite.py
respectively to match their specialised usage.The text was updated successfully, but these errors were encountered: