Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor process_and_combine.py #106

Open
dfulu opened this issue Dec 23, 2024 · 0 comments
Open

Refactor process_and_combine.py #106

dfulu opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working discussion

Comments

@dfulu
Copy link
Member

dfulu commented Dec 23, 2024

The process_and_combine.py file has two versions of the function

  • process_and_combine_datasets() which is only used in PVNetUKRegional
  • process_and_combine_site_sample_dict() which is only used in SitesDataset

I think process_and_combine_datasets() and process_and_combine_site_sample_dict() should either be refactored to share more code (there is a lot of copy-pasting going on) or they should be moved into pvnet_uk_regional.py and site.py respectively to match their specialised usage.

@dfulu dfulu added bug Something isn't working discussion labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion
Projects
None yet
Development

No branches or pull requests

1 participant