Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change numpy_batch to numpy_sample #103

Open
Tracked by #98
peterdudfield opened this issue Dec 23, 2024 · 1 comment · May be fixed by #105
Open
Tracked by #98

Change numpy_batch to numpy_sample #103

peterdudfield opened this issue Dec 23, 2024 · 1 comment · May be fixed by #105
Assignees
@Tim1119
Labels
good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Dec 23, 2024 •
edited by dfulu
Loading

We should rename numpy_batch to numpy_sample, becasuse we only deal with samples, not batches
@peterdudfield peterdudfield added the good first issue Good for newcomers label Dec 23, 2024
@Tim1119
Copy link

Tim1119 commented Dec 23, 2024

Hi, I'd like to work on this issue. Could you please assign it to me?

@peterdudfield peterdudfield mentioned this issue Dec 23, 2024
Open
20 tasks
@dfulu dfulu changed the title Change numpy_batch to numpy_sampler Change numpy_batch to numpy_sample Dec 23, 2024
@Tim1119 Tim1119 linked a pull request Dec 23, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim1119 Tim1119

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: renamed numpy_batch to numpy_sample throughout the codebase Tim1119/ocf-data-sampler
2 participants
@peterdudfield @Tim1119