This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
Bug: drop_pv_systems_which_produce_overnight expects normalised data, but it doesn't receive normalised data.
#664
Labels
bug
Something isn't working
Comments
JackKelly
changed the title
drop_pv_systems_which_produce_overnight expected normalised data, but it doesn't receive normalised data.drop_pv_systems_which_produce_overnight expects normalised data, but it doesn't receive normalised data.
JackKelly
added a commit
that referenced
this issue
May 17, 2022
|
Why does it matter if its normalised or not? |
|
Here's the code (
Note that the threshold (defined on line 546) is a "normalised" threshold. If the PV power isn't normalised, then the threshold is way too low to have much effect! I'm pretty confident this is a "real" bug 🙂 |
|
ah i forgot about the threshold - thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
nowcasting_dataset.data_sources.pv.pv_data_source.drop_pv_systems_which_produce_overnightexpected power values to be normalised. But, whendrop_pv_systems_which_produce_overnightis called, it is given raw un-normalised power values.The text was updated successfully, but these errors were encountered: