Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt batches silent padding #281

Open
Sukh-P opened this issue Nov 29, 2024 · 0 comments
Open

Adapt batches silent padding #281

Sukh-P opened this issue Nov 29, 2024 · 0 comments

Comments

@Sukh-P
Copy link
Member

Sukh-P commented Nov 29, 2024

Currently we have the adapt_batches configuration setting which allows the _adapt_batches function to modify the batch shape, I have recently through a configuration mistake noticed if you supply a sample that includes NWPs with width and height smaller than the output size that it will pad the NWP data in the samples with 0 values, as per torchvisions center_crop documentation .

This is done silently currently, I think we should either explicitly throw an exception for this case of input size smaller than requested output size as I don't see it as a case we want to support/part of the original intention of this function or at least throw a warning so it's more obvious this is happening, keen to hear thoughts on this, thanks! @peterdudfield @dfulu @AUdaltsova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant