Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-typescript-helpers documentation #2044

Open
thesammiller opened this issue Dec 6, 2024 · 3 comments
Open

openapi-typescript-helpers documentation #2044

thesammiller opened this issue Dec 6, 2024 · 3 comments
Assignees

Comments

@thesammiller
Copy link

thesammiller commented Dec 6, 2024

Per the openapi-typescript-helpers package README.MD:

This package isn’t as well-documented as the others, so it’s a bit “use at your own discretion.”

I am opening an issue to start a conversation about adding documentation. I would like to offer help in documenting as this package has recently helped me and the message about documentation gave me some pause as I reviewed it. While I'm not claiming to be an expert, I think some basic documentation could be added, but I am new to this project and welcome any direction.

I think import examples like in the openapi-typescript [README.md] (https://github.com/openapi-ts/openapi-typescript/blob/main/packages/openapi-typescript/README.md) and a code example like in the openapi-fetch [README.md] (https://github.com/openapi-ts/openapi-typescript/blob/main/packages/openapi-fetch/README.md) would be a reasonable starting place. If that sounds good I can try to put something together and submit a PR linking to this issue.

@drwpow
Copy link
Contributor

drwpow commented Dec 10, 2024

Tagging @kerwanp who may have thoughts on this. My rough opinion is that all documentation is welcome, even for beta libraries. As long as it’s flagged appropriately with “beta” in the sidebar (Vitepress supports this and in titles I think), I’d be +1 for adding. But I know there’s already a PR to get this started: #2006

@kerwanp
Copy link
Contributor

kerwanp commented Dec 21, 2024

In my opinion, for openapi-typescript-helpers it would be overkilled to have a complete new section for just openapi-typescript-helpers which is a small types library mostly used internally or by projects that anyway requires a certain knowledge about Typescript types. Maybe a new page Helpers under the openapi-typescript could work.

This led me to a question. @drwpow is there a reason why the helpers are not part of the openapi-typescript package (under openapi-typescript/helpers)?

@drwpow
Copy link
Contributor

drwpow commented Dec 21, 2024

This led me to a question. @drwpow is there a reason why the helpers are not part of the openapi-typescript package (under openapi-typescript/helpers)?

Yeah good question! 2 main reasons:

  1. openapi-typescript-helpers came from openapi-fetch, not openapi-typescript
  2. openapi-typescript-helpers are a dep of openapi-fetch. If they were moved into openapi-typescript then it would make that a dep of openapi-fetch, which has a lot of node_modules weight by comparison that openapi-fetch doesn’t need. Even though that doesn’t go to the client or anything, I still like to limit downloads and network transfer (both for consideration of end users but also being a generally good OSS citizen for npm etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants