Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] transfered app shared with user lost because of typo #531

Open
parisni opened this issue Oct 25, 2024 · 1 comment
Open

Comments

@parisni
Copy link

parisni commented Oct 25, 2024

hi,
very useful (undocumented yet?) allow-transfer-app to change ownership of a given app to an other user.

sadly if one makes a typo in the name of the user to share with, then the app is kind of lost and the only possible action is an admin to kill that app.

few proposal:

  • only allow to share the app with connected people, and build a list (instead of free text)
  • allow the initial owner to bring back it's instance (based on the instance name ?)
  • allow the admin to change the ownership in the admin menu ?

Thanks a lot !

@parisni parisni changed the title transfered app shared with user lost because of typo [feature request] transfered app shared with user lost because of typo Oct 25, 2024
@LEDfan
Copy link
Member

LEDfan commented Oct 28, 2024

Hi, first of all good to know you are interested in this feature! We will add the feature to the docs, it was not yet added because the feature is not very polished yet.

Regarding your suggestions:

only allow to share the app with connected people, and build a list (instead of free text)

For sure this would be a nice addition, but it requires a bit of additional work, since ShinyProxy currently doesn't maintain a complete list of online users. In addition, I think that some shinyproxy-admins do not want that shinyproxy users are able to get a full list of users, so we will need to add a flag for this.

We can definitely add the two other suggestions as well. For now we don't have concrete plans to extend the feature, if more people are interested we can add it. Of course you are always welcome to sponsor this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants