Agregate soil results with the rest of the scene #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue is encounter with
sorted
function in_agregate
function, l.35 of CaribuScene.py while activating soil_mesh.The activation of soil_mesh leads to extend the
groups
list (l.540 CaribuScene.run(...) in CaribuScene.py) with string labels"soil"
. This list is given afterward in l.655raw[band][k] = _agregate(output[k], groups, list)
. This leads to aTypeError
given by thesorted
function, because the listgroups
blendsint
andstr
elements.I didn't want to replace the soil label in all the package, so only in the function
_agregate
we replace"soil"
by -9999 (I supposed all the other labels were >= 0), and then put it back to"soil"
.This bug was encountered with the package alinea.caribu on fredboudon