You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know if this counts as something that won't be fixed for backwards compatability, but if the agent starts an episode on the exit (as in seed 1926574277), then
miner.cpp initializes diamonds_remaining as 0
Miner::game_step calls BasicAbstractGame::game_step() first before updating diamonds_remaining
BasicAbstractGame::game_step() calls for collision handling
Miner::handle_agent_collision checks the (unchanged) diamonds_remaining value, sees it's zero, and immediately exits the episode.
The text was updated successfully, but these errors were encountered:
This is easily fixed by initializing diamonds_remaining to a sentinel value like -1. If this is something y'all are interested in fixing I'd be happy to write the PR.
Thanks for investigating and letting us know, but unfortunately we don't want to change the behavior of the published environments. I think there has been a couple more reports like this, so if you wanted to make a PR to start a KNOWN_ISSUES.md file with this issue, linked from the README, I'd be happy to approve that.
I don't know if this counts as something that won't be fixed for backwards compatability, but if the agent starts an episode on the exit (as in seed 1926574277), then
The text was updated successfully, but these errors were encountered: