Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maximum precision for afterTimestamp and modified #102

Open
nickevansuk opened this issue Jul 1, 2021 · 2 comments
Open

Use maximum precision for afterTimestamp and modified #102

nickevansuk opened this issue Jul 1, 2021 · 2 comments

Comments

@nickevansuk
Copy link
Contributor

nickevansuk commented Jul 1, 2021

There's an issue where timestamps get truncated: if precision in the feed is different to the precision in the database then RPDE will fail

Recommend using the highest level of precision possible and ensuring it matches the database.

Example of nanoseconds: 1620400023901660 (fits within max int in PHP: 9223372036854775807)

@nathansalter
Copy link

This is what we use on Bookteq currently to solve this exact issue. Haven't had any issues with it so far, and we're well away from hitting the limit. Doesn't fit within 32 bit signed/unsigned ints, but that's much more of a language problem to solve. Most platforms nowadays are 64bit, with the notable exception of the Raspberry Pi. If you're working on a 32 bit platform, it should be recommended to use second precision rather than milli/nano.

@nathansalter
Copy link

This is related to this issue here: #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants