Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint issues and ensure conformance across code #648

Open
lukehesluke opened this issue Feb 28, 2024 · 0 comments
Open

Fix ESLint issues and ensure conformance across code #648

lukehesluke opened this issue Feb 28, 2024 · 0 comments

Comments

@lukehesluke
Copy link
Contributor

packages/openactive-integration-tests/.eslintignore contains a list of files which are ignored by ESLint presently. These are old files which use inconsistent conventions and some shorthand styles which are often considered to be ill-advised (e.g. https://eslint.org/docs/latest/rules/no-return-assign)

The goal of this issue is to:

  1. Remove that .eslintignore file and fix all ESLint errors that come up.
  2. Remove all the eslint-disable comments. These turn off an ESLint rule for an entire file, which is considered to be too broad. When there is a good reason to have a singular exception, comments that simply disable a rule for one line (e.g. eslint-disable-next-line) can be used.
    a. And fix all ESLint errors that come up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💡Ideas
Development

No branches or pull requests

1 participant