Geo coordinates must be floats

[thill-odi]

geo.latitude and geo.longitude need to be expressed as floats with a minimum precision of four decimal places. They MUST NOT be rounded to integers.

[Lathrisk]

I noticed that this issue states that the precision should be 4 or more decimal places, but the OpenActive spec specifies 2 or more decimal places.

[Lathrisk]

And to mix that up a little more, there is already a precision rule that covers latitude to 3 decimal places.

[nickevansuk]

I was just about to comment on this issue @Lathrisk but you beat me to it with your discovery of the precision rule - the issue itself is in fact largely redundant, though hopefully still a good academic exercise to get your head into the codebase.

minDecimalPlaces currently displays a notice that covers the requirement here, and is only used for latitude and longitude.

The reason this is a notice and not an error or warning is that some data does actually legitimately have 1, 2 or 3 decimal places. Limited historical context: openactive-archive/developer-microsite#39

A real example:

Stevenage Swimming Centre, St George's Way, Stevenage, Hertfordshire, SG1 1XY, United Kingdom
51.9047222, -0.2

Data model reference:

https://github.com/openactive/data-models/blob/2acafeed5636973d38e4c456ca035fdd683ecf18/versions/2.x/models/GeoCoordinates.json#L21-L40

    "latitude": {
      "fieldName": "latitude",
      "sameAs": "https://schema.org/latitude",
      "requiredType": "https://schema.org/Number",
      "minDecimalPlaces": 3,
      "example": 51.522338,
      "description": [
        "The latitude of a location. For example 51.522338 (WGS 84)."
      ]
    },
    "longitude": {
      "fieldName": "longitude",
      "sameAs": "https://schema.org/longitude",
      "requiredType": "https://schema.org/Number",
      "minDecimalPlaces": 3,
      "example": -0.083437,
      "description": [
        "The longitude of a location. For example -0.083437 (WGS 84)."
      ]
    }

[Lathrisk]

Thanks for the update, Nick. That makes sense. It's been a good introduction to the validator, the spec, and the models!

[nickevansuk]

Closing this based on the above